Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-3250] - Add revocable_tokens parameter to ably_api_key resource #171

Merged

Conversation

graham-russell
Copy link
Member

Ably API keys support token revocation. This commit updates the Ably Terraform provider to allow configuring token revocation for Ably Keys.

Ably key tests have also been updated with the Token revocation parameter.

More information on Token Revocation can be found in the Ably documentation

@graham-russell graham-russell marked this pull request as draft February 1, 2024 11:17
@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch 2 times, most recently from aff589a to fc2e174 Compare February 1, 2024 11:39
@graham-russell graham-russell marked this pull request as ready for review February 1, 2024 14:07
@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch 2 times, most recently from 6ad3ef9 to 64aa11e Compare February 5, 2024 11:32
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch from 64aa11e to f6e8ed3 Compare February 7, 2024 13:02
Ably API keys support token revocation. This commit updates the Ably Terraform provider to allow configuring token revocation for Ably Keys.

Ably key tests have also been updated with the Token revocation parameter.

More information on Token Revocation can be found in the [Ably documentation](https://ably.com/docs/auth/revocation)
@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch from f6e8ed3 to fae0b94 Compare February 7, 2024 13:09
@graham-russell graham-russell merged commit 7c2e8da into main Feb 7, 2024
2 checks passed
@graham-russell graham-russell deleted the feature/INF-3250-add-ably-key-revocable-tokens-param branch February 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants